Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hreview backcompat #255

Merged
merged 6 commits into from Mar 9, 2024
Merged

Fix hreview backcompat #255

merged 6 commits into from Mar 9, 2024

Conversation

gRegorLove
Copy link
Member

Fixes #155

  • rel="self bookmark" -> u-url
  • class="reviewer" -> p-author h-card
  • fix class="item hproduct", was backcompat parsing as vevent instead of hproduct
  • adds unit tests
  • comment out a unit test that was not making any assertions or failures.
  • fix some syntax/warnings in newer versions of PHPUnit

@gRegorLove
Upate hreview backcompat
46a90f9 
Parse rel="self bookmark" as u-url
@gRegorLove
Update hreview backcompat
35c846c 
Set backcompat parser for `item hproduct` correctly.
Add tests for `item vevent` and `item hproduct`.
@gRegorLove
Comment out a test with no assertions
f1ffcab
@gRegorLove
Update tests
8e571f8 
Fixes some warnings in newer versions of PHPUnit.
@gRegorLove
Update hreview backcompat
113d3af 
Fix reviewer -> p-author h-card backcompat
artlung
artlung reviewed Mar 8, 2024
View reviewed changes
tests/Mf2/ParserTest.php Outdated Show resolved Hide resolved
tantek
tantek requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch from indiewebcamp.com references to indieweb.org and use https instead (including example.com URLs)?

@gRegorLove
Copy link
Member Author

gRegorLove commented Mar 8, 2024 •
edited

Updated indieweb.org URL and https://example.com in tests.

Updated the test @artlung brought up so it has an assertion of no matches instead of calling fail() if a match is found.

Edit: this should resolve all the "risky" tests that PHPUnit was reporting (#250 (comment))

@gRegorLove gRegorLove merged commit 103b34e into microformats:main Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@artlung artlung Awaiting requested review from artlung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hreview backcompat
3 participants
@gRegorLove @tantek @artlung