Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test #257

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix failing test #257

merged 1 commit into from
Apr 15, 2024

Conversation

gRegorLove
Copy link
Member

@gRegorLove gRegorLove commented Apr 7, 2024

The original test from #84 (and microformats/mf2py#62) was following a redirect from a short domain ensuring that the final domain was used to resolve relative URLs, by comparing the final URL of a photo in the post. The URL of the photo in that post changed, so this test started failing.

Updated the test to only check that the domain in the final photo URL is the one we expect.

Edit: this should fix the failing automated tests that I saw here: https://github.com/microformats/php-mf2/actions

@gRegorLove gRegorLove requested a review from tantek April 7, 2024 22:59
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good enough to catch property value parsing, independent of redirects of final path.

Do we have an issue on how redirects should work?

I would have expected that parsers don't do any redirect processing because parsers should not need to retrieve any URLs in order to parse some HTML.

The client of a parser should be expected to handle any redirects of any URL properties, not the parser.

@gRegorLove gRegorLove merged commit e35bb9f into microformats:main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants