Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slash to normalized absolute URLs in parsed JSON #111

Conversation

jgarber623
Copy link
Member

Referencing this conversation in #microformats, I've added trailing slashes in parsed JSON for absolute URLs of type http://example.com.

For example, http://example.com would normalize to http://example.com/. This should conform with URL parsing libraries (e.g. the Addressable Ruby gem) and similar specs (e.g. IndieAuth user profile URLs).

The relevant language from microformats2-parsing:

return the normalized absolute URL of the gotten value, following the containing document's language's rules for resolving relative URLs (e.g. in HTML, use the current URL context as determined by the page, and first element, if any).

It's a small but significant change, so feedback is greatly appreciated. Thanks!

@jgarber623
Copy link
Member Author

There wasn't a lot of support for this in IRC/Slack, so… closing!

@jgarber623 jgarber623 closed this Aug 29, 2019
@jgarber623 jgarber623 deleted the update-normalized-absolute-urls branch August 29, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant