Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and reformat datetimes only when defined via value-class pattern #89

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

jmacdotorg
Copy link
Contributor

This change updates four tests dealing with datetime attributes. The MF2 spec (as of July 2018) specifies that datetime attributes should be parsed and reformatted only when they are defined in the original document via value-class pattern. In every other instance, they are to be treated as literal strings, and passed through to the resulting JSON file unchanged.

The updates here deal specifically with datetimes not defined via value-class pattern, and which therefore should have JSON representations that match their appearance in their respective source HTML files.

@sknebel
Copy link
Member

sknebel commented Jul 30, 2018

Thank you! Appears correct, so +1 to merge for me.

@gRegorLove gRegorLove merged commit 070c19d into microformats:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants