Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[goto] implement waitUntil: 'auto' #160

Closed
Kikobeats opened this issue Apr 6, 2020 · 0 comments · Fixed by #171
Closed

[goto] implement waitUntil: 'auto' #160

Kikobeats opened this issue Apr 6, 2020 · 0 comments · Fixed by #171

Comments

@Kikobeats
Copy link
Member

Kikobeats commented Apr 6, 2020 •
edited

People don't care if they need to wait for 'load' or 'networkidle*' event.

Implement an auto mode that follows this behavior.

  • Run 'networkidle*' and 'load' event on parallel (maybe two tabs?).
  • Add timeout over network event for preventing infinite waiting (10s?).
  • If the timeout is not exceeded, use 'networkidle*' event response. Otherwise, fallback into 'load'.

Testing URLs

Related
@Kikobeats Kikobeats changed the title Implement waitUntil: 'auto' [goto] implement waitUntil: 'auto' Apr 16, 2020
Kikobeats added a commit that referenced this issue May 9, 2020
@Kikobeats
feat: add waitUntil: 'auto'
5db3931 
closes #160
@Kikobeats Kikobeats mentioned this issue May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add waitUntil: 'auto' microlinkhq/browserless
1 participant
@Kikobeats