refactor: pass uri to cheerio (#621)

microlinkhq · Feb 27, 2023 · 340a15b · 340a15b
1 parent 51d0d1e
commit 340a15b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/packages/metascraper-manifest/test/snapshots/index.js.snap b/packages/metascraper-manifest/test/snapshots/index.js.snap
diff --git a/packages/metascraper/src/index.js b/packages/metascraper/src/index.js
@@ -1,10 +1,10 @@
 'use strict'
 
 const { isUrl } = require('@metascraper/helpers')
+const { load } = require('cheerio')
 const whoops = require('whoops')
 
 const { loadRules, mergeRules } = require('./rules')
-const loadHTML = require('./load-html')
 const getData = require('./get-data')
 
 const MetascraperError = whoops('MetascraperError')
@@ -13,7 +13,7 @@ module.exports = rules => {
   const loadedRules = loadRules(rules)
   return async ({
     url,
-    html,
+    html = '',
     rules: inlineRules,
     validateUrl = true,
     ...props
@@ -27,7 +27,7 @@ module.exports = rules => {
 
     return getData({
       url,
-      htmlDom: loadHTML(html),
+      htmlDom: load(html, { baseURI: url }),
       rules: mergeRules(inlineRules, loadedRules),
       ...props
     })

diff --git a/packages/metascraper/src/load-html.js b/packages/metascraper/src/load-html.js