fix(audio): don't consider iframe referencing itself

microlinkhq · Sep 17, 2023 · 815534a · 815534a
1 parent 4409000
commit 815534a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/packages/metascraper-audio/index.js b/packages/metascraper-audio/index.js
@@ -84,14 +84,13 @@ module.exports = ({ getIframe = _getIframe } = {}) => {
         const srcs = []
 
         iframe.each(function () {
-          const src = $(this).attr('src')
-          const normalizedUrl = normalizeUrl(url, src)
+          const iframeUrl = normalizeUrl(url, $(this).attr('src'))
           if (
-            typeof normalizedUrl === 'string' &&
-            normalizedUrl.startsWith('http') &&
-            srcs.indexOf(normalizedUrl) === -1
+            typeof iframeUrl === 'string' &&
+            iframeUrl !== url &&
+            srcs.indexOf(iframeUrl) === -1
           ) {
-            srcs.push(normalizedUrl)
+            srcs.push(iframeUrl)
           }
         })
 

diff --git a/packages/metascraper-helpers/test/index.js b/packages/metascraper-helpers/test/index.js
@@ -58,6 +58,13 @@ test('.normalizeUrl', t => {
   )
   t.is(normalizeUrl('https://example.com/'), 'https://example.com/')
   t.is(normalizeUrl('https://example.com'), 'https://example.com/')
+
+  t.is(normalizeUrl('https://www.example.com', 'https://www.example.com/foo'), 'https://www.example.com/foo')
+  t.is(normalizeUrl('https://www.example.com', '/foo'), 'https://www.example.com/foo')
+  t.is(normalizeUrl('https://www.example.com', 'file.html'), 'https://www.example.com/file.html')
+  t.is(normalizeUrl('https://www.example.com', 'data:text/html;base64,PGh0bWw+SGVsbG8sIHdvcmxkITwvaHRtbD4='), 'data:text/html;base64,PGh0bWw+SGVsbG8sIHdvcmxkITwvaHRtbD4=')
+  t.is(normalizeUrl('https://www.example.com', 'javascript:alert(\'Hello, world!\');'), undefined)
+  t.is(normalizeUrl('https://www.example.com', 'javascript:void(0)'), undefined)
 })
 
 test('.author', t => {