Skip to content

Commit

Permalink
perf(spotify): remove key query parameters (#520)
Browse files Browse the repository at this point in the history
* build: update dependencies

* refactor(spotify): remove key query parameters
  • Loading branch information
Kikobeats committed Mar 30, 2022
1 parent a318787 commit 94e8680
Show file tree
Hide file tree
Showing 11 changed files with 20 additions and 14 deletions.
2 changes: 1 addition & 1 deletion packages/metascraper-amazon/package.json
Expand Up @@ -23,7 +23,7 @@
],
"dependencies": {
"@metascraper/helpers": "^5.28.2",
"tldts": "~5.7.70"
"tldts": "~5.7.73"
},
"devDependencies": {
"lodash": "latest",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-clearbit/package.json
Expand Up @@ -29,7 +29,7 @@
"async-memoize-one": "~1.1.0",
"got": "~11.8.3",
"lodash": "~4.17.21",
"tldts": "~5.7.70"
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-instagram/package.json
Expand Up @@ -25,7 +25,7 @@
"@metascraper/helpers": "^5.28.2",
"jsdom": "~19.0.0",
"lodash": "~4.17.21",
"tldts": "~5.7.70"
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
4 changes: 2 additions & 2 deletions packages/metascraper-logo-favicon/package.json
Expand Up @@ -26,8 +26,8 @@
"@keyvhq/memoize": "~1.6.6",
"@metascraper/helpers": "^5.28.2",
"lodash": "~4.17.21",
"reachable-url": "~1.6.7",
"tldts": "~5.7.70"
"reachable-url": "~1.6.8",
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-media-provider/package.json
Expand Up @@ -32,7 +32,7 @@
"p-reflect": "~2.1.0",
"p-retry": "~4.6.1",
"p-timeout": "~4.1.0",
"tldts": "~5.7.70",
"tldts": "~5.7.73",
"youtube-dl-exec": "~2.0.8"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-soundcloud/package.json
Expand Up @@ -24,7 +24,7 @@
],
"dependencies": {
"@metascraper/helpers": "^5.28.2",
"tldts": "~5.7.70"
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
8 changes: 7 additions & 1 deletion packages/metascraper-spotify/index.js
Expand Up @@ -6,6 +6,7 @@ const memoize = require('@keyvhq/memoize')
const got = require('got')

const {
sanetizeUrl,
composeRule,
memoizeOne,
normalizeUrl
Expand All @@ -27,7 +28,12 @@ const createSpotify = ({ gotOpts, keyvOpts }) => {
}
}

return asyncMemoizeOne(memoize(spotify, keyvOpts))
return asyncMemoizeOne(
memoize(spotify, keyvOpts, {
key: url =>
sanetizeUrl(url, { removeQueryParameters: [/^utm_\w+/i, 'si'] })
})
)
}

const isValidUrl = memoizeOne(url => getDomainWithoutSuffix(url) === 'spotify')
Expand Down
4 changes: 2 additions & 2 deletions packages/metascraper-spotify/package.json
Expand Up @@ -27,8 +27,8 @@
"@metascraper/helpers": "^5.28.2",
"async-memoize-one": "~1.1.0",
"got": "~11.8.3",
"spotify-url-info": "~3.0.0",
"tldts": "~5.7.70"
"spotify-url-info": "~3.0.2",
"tldts": "~5.7.73"
},
"devDependencies": {
"kind-of": "latest",
Expand Down
4 changes: 2 additions & 2 deletions packages/metascraper-telegram/package.json
Expand Up @@ -24,8 +24,8 @@
"dependencies": {
"@metascraper/helpers": "^5.28.2",
"async-memoize-one": "~1.1.0",
"css-urls": "~2.0.22",
"tldts": "~5.7.70"
"css-urls": "~2.0.23",
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-uol/package.json
Expand Up @@ -25,7 +25,7 @@
],
"dependencies": {
"@metascraper/helpers": "^5.28.2",
"tldts": "~5.7.70"
"tldts": "~5.7.73"
},
"devDependencies": {
"mocha": "latest",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-youtube/package.json
Expand Up @@ -26,7 +26,7 @@
"@metascraper/helpers": "^5.28.2",
"get-video-id": "~3.5.3",
"p-locate": "~5.0.0",
"reachable-url": "~1.6.7"
"reachable-url": "~1.6.8"
},
"devDependencies": {
"lodash": "latest",
Expand Down

0 comments on commit 94e8680

Please sign in to comment.