Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for metascraper packages #676

Closed
Kikobeats opened this issue Dec 15, 2023 · 0 comments · Fixed by #677
Closed

Add types for metascraper packages #676

Kikobeats opened this issue Dec 15, 2023 · 0 comments · Fixed by #677

Comments

@Kikobeats
Copy link
Member

Now that we have well types for metascraper package:

https://github.com/microlinkhq/metascraper/blob/master/packages/metascraper/src/index.d.ts

It's also necessary to add types per every metascraper-* package. Similar to:

declare module 'metascraper-*' {
  export default function rules(): import('metascraper').RuleSet;
}

but also declaring the options available in every package.
@Kikobeats Kikobeats mentioned this issue Dec 15, 2023
Closed
Kikobeats added a commit that referenced this issue Dec 16, 2023
@Kikobeats
feat: add types for packages
91a1cee 
Closes #676
@Kikobeats Kikobeats mentioned this issue Dec 16, 2023
Merged
Kikobeats added a commit that referenced this issue Dec 18, 2023
@Kikobeats
feat: add types for packages (#677)
8b8339c 
* feat: add types for packages

Closes #676

* refactor(types): use declare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add types for packages microlinkhq/metascraper
1 participant
@Kikobeats