Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixes #207: parse multiple json-ld blocks #208

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

slavaGanzin
Copy link
Contributor

@Kikobeats
Copy link
Member

@slavaGanzin super awesome, thanks for that!

Can you add an integration test here just to be sure the URL you are targetting (https://bykvu.com) is returning the information you expect after this been merged?

@slavaGanzin
Copy link
Contributor Author

@Kikobeats I made test by example, but running npm test in root of repo failing with:

Error: Cannot find module 'metascraper-audio'
Require stack:
- /home/vganzin/github/metascraper/packages/metascraper-audio/test/index.js
- /home/vganzin/github/metascraper/packages/metascraper-audio/node_modules/mocha/lib/mocha.js
- /home/vganzin/github/metascraper/packages/metascraper-audio/node_modules/mocha/lib/cli/one-and-dones.js
- /home/vganzin/github/metascraper/packages/metascraper-audio/node_modules/mocha/lib/cli/options.js
- /home/vganzin/github/metascraper/packages/metascraper-audio/node_modules/mocha/bin/mocha
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:623:15)
    at Function.Module._load (internal/modules/cjs/loader.js:527:27)
    at Module.require (internal/modules/cjs/loader.js:681:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/vganzin/github/metascraper/packages/metascraper-audio/test/index.js:5:45)
    at Module._compile (internal/modules/cjs/loader.js:774:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)
    at Module.load (internal/modules/cjs/loader.js:641:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Module.require (internal/modules/cjs/loader.js:681:19)
    at require (internal/modules/cjs/helpers.js:16:16)

And I ran npm install before and lerna bootsrapped packages...

I hope it will work in travis

@Kikobeats Kikobeats merged commit 0c8ee94 into microlinkhq:master Sep 12, 2019
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 75.904% when pulling 7f018a4 on slavaGanzin:multiple-json-ld into 87576a1 on microlinkhq:master.

@Kikobeats
Copy link
Member

Released at v5.7.0, welcome as metascraper contributor 🎉

@slavaGanzin slavaGanzin deleted the multiple-json-ld branch September 12, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants