Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use url-regex-safe to fix url-regex vulnerability #297

Merged
merged 2 commits into from Aug 20, 2020

Conversation

ikhemissi
Copy link
Contributor

The package url-regex has a Regular Expression Denial of Service vulnerability and it looks like it is not maintained anymore.
This PR replaces url-regex with url-regex-safe which solves the problem above while providing a drop-in replacement for url-regex.

ikhemissi and others added 2 commits August 19, 2020 19:46
The package [url-regex](https://www.npmjs.com/package/url-regex) has a [Regular Expression Denial of Service vulnerability](https://www.npmjs.com/advisories/1550) and it looks like it is [not maintained anymore](kevva/url-regex#70).
This PR replaces url-regex with [url-regex-safe](https://www.npmjs.com/package/url-regex-safe) which solves the problem above while providing a drop-in replacement for url-regex.
@Kikobeats
Copy link
Member

Thanks for this!

@Kikobeats Kikobeats merged commit 157ef61 into microlinkhq:master Aug 20, 2020
@ikhemissi ikhemissi deleted the fix-url-regex-audit-issue branch August 20, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants