Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): validateUrl is optional #571

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix(types): validateUrl is optional #571

merged 1 commit into from
Jul 20, 2022

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Jul 20, 2022 •
edited
Loading

closes #570

@Kikobeats Kikobeats mentioned this pull request Jul 20, 2022
Closed
2 tasks
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 98.135% when pulling 60379bb on types into aee7bde on master.

@Kikobeats Kikobeats marked this pull request as ready for review July 20, 2022 11:30
@Kikobeats Kikobeats merged commit f0156f1 into master Jul 20, 2022
@Kikobeats Kikobeats deleted the types branch July 20, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metascraper@5.29.17 adds required validateUrl property to ScrapOptions (breaking change in patch release)
2 participants
@Kikobeats @coveralls