Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent pass cardSize as DOM property #166

Merged
merged 1 commit into from
Nov 11, 2019
Merged

fix: prevent pass cardSize as DOM property #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react/src/components/Card/CardMedia/Controls/SeekButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styled from 'styled-components'
import MediaButton from './MediaButton'
import { media, isLarge } from '../../../../utils'

const Backward = props => (
const Backward = ({ cardSize, ...props }) => (
<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 29' {...props}>
<path
fill='#FFF'
Expand All @@ -17,7 +17,7 @@ const Backward = props => (
</svg>
)

const Forward = props => (
const Forward = ({ cardSize, ...props }) => (
<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 29' {...props}>
<path
fill='#FFF'
Expand All @@ -44,7 +44,7 @@ const SeekIcon = styled('svg')`
`

const SeekButtonWrap = styled(MediaButton)`
margin: 0 ${({ cardSize }) => isLarge(cardSize) ? '28px' : '3px'};
margin: 0 ${({ cardSize }) => (isLarge(cardSize) ? '28px' : '3px')};
`

const SeekButton = ({ type = 'rewind', cardSize, ...props }) => {
Expand Down