New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move rootNode logic out of vanilla #189

Merged

Kikobeats merged 1 commit into master from next

Feb 7, 2020

Member

Kikobeats commented Feb 7, 2020

This change is motivated since the vanilla version needs to mount the microlink card into the node selected using a dom query selector.

On the other hand, Vue/Angular needs to reuse the same node.

So the thing I did is to remove the rootNode logic out of the vanilla bundle, meaning:

The node used for mounting the component will be rootNode || el
For reusing the mounted node, just setup the logic before and after call vanilla bundle.

This PR is not completed; Need to update the Vue/Angular logic for doing that workflow:

Create rootNode and pass it to microlink/vanilla.
do cleanup action (el.remove() after exec microlink/vanilla.


          build: move rootNode logic out of vanilla

423586d

Kikobeats merged commit 4c960c2 into master

Kikobeats deleted the next branch

February 7, 2020 12:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment