Add proper support for onComment, onToken
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the position fixer into the function * Use some assertions for things TS can’t figure out, which are compiled away in production * Format some code one one line to be smaller * Reword some test case messages
github-actions
bot
added
👋 phase/new
|
Thank @JounQin! I refactored your PR a bit (see last commit). The approach looks good! 👍 |
wooorm
added
🦋 type/enhancement
5 tasks
wooorm
changed the title
acornOptions.onComment arrayonComment, onToken
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Closes GH-3.
Closes GH-4.