Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make definitions available to extensions #121

Closed
4 tasks done
tripodsan opened this issue Oct 4, 2022 · 2 comments · Fixed by #122
Closed
4 tasks done

Make definitions available to extensions #121

tripodsan opened this issue Oct 4, 2022 · 2 comments · Fixed by #122
Labels
💪 phase/solved Post is done

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Oct 4, 2022 •
edited

Initial checklist

Problem

i'm writing an extension where I would need the definitions defined in the document.

Solution

the definitions should be available either via the context this.definitions or via getData('mediaDefinitions').
the latter is probably better.

Alternatives

I could probably overwrite all the definition related enter and exit methods, and track them as well, but this sounds like a wrong approach.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 4, 2022
@wooorm
Copy link
Member

wooorm commented Oct 4, 2022

Feel free to create a PR that exposes it, just like 'tightStack'?

tripodsan added a commit to adobe-rnd/micromark that referenced this issue Oct 4, 2022
@tripodsan
feat: add definitions to CompileDataFields
61b3efd 
fixes micromark#121
@tripodsan tripodsan mentioned this issue Oct 4, 2022
Merged
5 tasks
wooorm pushed a commit that referenced this issue Oct 6, 2022
@tripodsan
micromark: add definitions on exposed fields
c0602c2 
Closes GH-121.
Closes GH-122.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Oct 6, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

micromark: add definitions on exposed fields adobe-rnd/micromark
2 participants
@tripodsan @wooorm