Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update split-string #19

Closed
simevo opened this issue Jan 3, 2019 · 1 comment
Closed

Update split-string #19

simevo opened this issue Jan 3, 2019 · 1 comment

Comments

@simevo
Copy link

simevo commented Jan 3, 2019

Please update split-string from 3.0.2 to 6.0.0

according to its changelog, the keepQuotes option has been removed

updating this dependency breaks most tests so I guess that you need tweak some code, but looking at lib/utils.js it's not obvious to me what should be changed
@jonschlinkert
Copy link
Member

Feel free to do a pull request with all tests passing and integration/regression tests in libraries that use this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonschlinkert @simevo