-
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replacing the regular expressions with algorithmic equivalents remediates performance issues. There are no doubt further performance enhancements that can be made to the code here, but this addresses the most critical. On my container, the performance tests added in this commit took less than 1 second to run with the code changes here compared to around 40 seconds using the current module code. (I also happen to think the algorithms are easier to understand, maintain, and debug in this form as well.)
- Loading branch information
Showing
2 changed files
with
130 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters