Fix: Put mm into bash mode for bash tests #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would appear that a section of the bash tests were being run without micromatch being given the `bash` option. Note: Supplying this option causes some of the tests to fail. In particular, it would appear that in bash mode `*` will match into directories like `**`, for example `*/c` will match `a/b/c`.
|
If I have misunderstood the purpose of that batch of tests, please accept my apologies. |
|
If I am right, then presumably the test in picomatch are also buggy and the tests can only be fixed by fixing picomatch. |
This was referenced Jul 13, 2020
If I recall correctly, the "bash" option wasn't the intent of the "bash" tests. those tests are from bash, and the intent was to test micromatch's node.js behavior against those. Sorry I know that's confusing. |
|
closing based on my previous comment. we can discuss further if I misunderstood something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that a section of the bash tests were being run without
micromatch being given the
bashoption.Note: Supplying this option causes some of the tests to fail. In
particular, it would appear that in bash mode
*will match intodirectories like
**, for example*/cwill matcha/b/c.