Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micrometer cloudwatch should publish StatisticSet when any aggregations are done client side. #1784

Open
ghost opened this issue Jan 10, 2020 · 3 comments
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with registry: cloudwatch A CloudWatch Registry related issue
Milestone

Comments

@ghost
Copy link

ghost commented Jan 10, 2020

Micrometer cloudwatch current publishes separate metrics for a Timer under different prefixes (avg, count, sum, max). Since Cloudwatch also does statistical aggregations this makes the client side aggregations a deterrent to being able to use the full capabilities of cloudwatch. Aggregation in itself is not a bad thing, but it needs to be sent to cloudwatch as an aggregation via a StatisticSet.

@shakuzen shakuzen added enhancement A general enhancement registry: cloudwatch A CloudWatch Registry related issue labels Jan 13, 2020
@shakuzen shakuzen added this to the 1.x milestone Jan 13, 2020
@shakuzen shakuzen added the help wanted An issue that a contributor can help us with label Jan 13, 2020
@shakuzen
Copy link
Member

Thank you for bringing this to our attention. Would you be willing to contribute a pull request for this?

@ghost
Copy link
Author

ghost commented Jan 13, 2020 via email

@thrxde
Copy link

thrxde commented Apr 29, 2020

To implement this feature, it is necessary to provide an "min" value in micrometer. see: min statistic for distribution summaries and timers #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with registry: cloudwatch A CloudWatch Registry related issue
Projects
None yet
Development

No branches or pull requests

2 participants