Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Shenandoah GC in JvmGcMetrics #1861

Closed
IRus opened this issue Feb 21, 2020 · 3 comments · Fixed by #2306
Closed

Support Shenandoah GC in JvmGcMetrics #1861

IRus opened this issue Feb 21, 2020 · 3 comments · Fixed by #2306
Labels
enhancement A general enhancement
Milestone
1.6.0

Comments

@IRus
Copy link
Contributor

IRus commented Feb 21, 2020 •
edited by shakuzen

Micrometer: 1.3.5
JDK: 11.0.6

Right now all metrics exported from JvmGcMetrics are 0.

See the OpenJDK Wiki for Shenandoah GC for more information on it. While the GC pause time metric (jvm.gc.pause) was working, we should also support the following:

  • jvm.gc.max.data.size
  • jvm.gc.live.data.size
  • jvm.gc.memory.allocated
@jkschneider jkschneider added this to the 1.5.0 milestone Mar 27, 2020
@shakuzen shakuzen added the enhancement A general enhancement label Apr 22, 2020
@shakuzen shakuzen modified the milestones: 1.5.0, 1.6.0 Apr 23, 2020
@asad-awadia

This comment has been minimized.

Sign in to view
@shakuzen

This comment has been minimized.

Sign in to view
@asad-awadia

This comment has been minimized.

Sign in to view
@shakuzen shakuzen mentioned this issue Oct 26, 2020
Closed
shakuzen added a commit to shakuzen/micrometer that referenced this issue Oct 26, 2020
@shakuzen
Support non-generational garbage collector metrics
bcda8d5 
There were some assumptions in JvmGcMetrics that the garbage collector was generational, with a designated young and old region. ZGC and Shenandoah are examples of OpenJDK garbage collectors that are not generational. GC metrics should be properly recorded with these changes.

Resolves micrometer-metrics#1861
Resolves micrometer-metrics#2305
@shakuzen shakuzen mentioned this issue Oct 26, 2020
Merged
shakuzen added a commit that referenced this issue Oct 28, 2020
@shakuzen
Support non-generational garbage collector metrics (#2306)
6d3fec0 
There were assumptions in JvmGcMetrics that the garbage collector was generational, with designated young and old regions. ZGC and Shenandoah are examples of OpenJDK garbage collectors that are not generational. GC metrics should be properly recorded for them with these changes.

Resolves #1861
Resolves #2305
This was referenced Jun 26, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Support non-generational garbage collector metrics shakuzen/micrometer
4 participants
@IRus @jkschneider @asad-awadia @shakuzen