Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for OkHttp ConnectionPool #1875

Closed
benhubert opened this issue Mar 3, 2020 · 2 comments
Closed

Add metrics for OkHttp ConnectionPool #1875

benhubert opened this issue Mar 3, 2020 · 2 comments
Labels
enhancement A general enhancement
Milestone
1.6.0

Comments

@benhubert
Copy link
Contributor

benhubert commented Mar 3, 2020 •
edited

Hi! I think it would be helpful to have metrics for OkHttp's ConnectionPool usage.

I already implemented this for us and created a PR. I'm uncertain about some implementation details, see my comments in the PR for details.
benhubert added a commit to benhubert/micrometer that referenced this issue Mar 3, 2020
@benhubert
added metrics for OkHttp connection pool micrometer-metrics#1875
39df5eb
@jkschneider
Copy link
Contributor

@benhubert Would you like to open a PR with this implementation? Seems like you've got it working...

@benhubert
Copy link
Contributor Author

Well, that was my intention, but seems that I forgot to open the PR. Thanks for your hint.
Now it's ready for review: #2066

@jkschneider jkschneider mentioned this issue May 8, 2020
Closed
@jkschneider jkschneider added the enhancement A general enhancement label May 8, 2020
@jkschneider jkschneider added this to the 1.6.0 milestone May 8, 2020
jkschneider pushed a commit that referenced this issue May 8, 2020
@benhubert
Added metrics for OkHttp connection pool #1875
a1b04f5
This was referenced Jun 26, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@jkschneider @benhubert