You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
publishPercentileHistogram for all Timers/Summaries is set by the very first Timer/Summary and publishPercentileHistogram flag in timers/summaries that are created after that is ignored.
Problematic change seems to be introduction of the second `StatsdLineBuilder lineBuilder(Meter.Id id, @nullable DistributionStatisticConfig distributionStatisticConfig)' method and the fact that initial overload without DSC parameter was kept in place and being used.
The second problem that builds on top of the first one is the fact that lineBuilderFunction is cached in StatsdMeterRegistry.lineBuilder(Meter.Id, DSC) method when it must be created every single time now as we must be able to configure 2 different DatadogStatsdLineBuilder's - one that generates percentileHistogram and reports as DISTRIBUTION and another one that reports as regular TIMER or HISTOGRAM.
The text was updated successfully, but these errors were encountered:
jonatan-ivanov
changed the title
[1.8.0-M3][StatsD.Datadog] Can't configure DISTRIBUTION on per-metric basis
Can't configure DISTRIBUTION on per-metric basis for Datadog
Oct 1, 2021
Describe the bug
publishPercentileHistogram for all Timers/Summaries is set by the very first Timer/Summary and publishPercentileHistogram flag in timers/summaries that are created after that is ignored.
Environment
openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
To Reproduce
How to reproduce the bug:
Expected behavior
See the failing tests above.
Additional context
Issue was introduced with this PR: https://github.com/micrometer-metrics/micrometer/pull/2745/files
Problematic change seems to be introduction of the second `StatsdLineBuilder lineBuilder(Meter.Id id, @nullable DistributionStatisticConfig distributionStatisticConfig)' method and the fact that initial overload without DSC parameter was kept in place and being used.
The second problem that builds on top of the first one is the fact that
lineBuilderFunction
is cached inStatsdMeterRegistry.lineBuilder(Meter.Id, DSC)
method when it must be created every single time now as we must be able to configure 2 different DatadogStatsdLineBuilder's - one that generates percentileHistogram and reports as DISTRIBUTION and another one that reports as regular TIMER or HISTOGRAM.The text was updated successfully, but these errors were encountered: