We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Hazelcast has two variations for IMap writing, "put" and "set".
Hazelcast's Spring Cache uses the latter (https://github.com/hazelcast/hazelcast/blob/master/hazelcast-spring/src/main/java/com/hazelcast/spring/cache/HazelcastCache.java#L114)
Micrometer counts the former (https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java#L125)
It should use localMapStats.getPutOperationCount() + localMapStats.getSetOperationCount()
localMapStats.getPutOperationCount() + localMapStats.getSetOperationCount()
Environment N/a
To Reproduce I don't have code, but anything @Cacheable in Spring that saves to Hazelcast should be enough.
@Cacheable
Expected behavior Cache "put" counts should report as non-zero
Additional context See also hazelcast/hazelcast#23063, which may change the implement from IMap set to IMap put
The text was updated successfully, but these errors were encountered:
I created #3558 to try to resolve this.
Sorry, something went wrong.
Update put count to include set count in HazelcastCacheMetrics
256a4b3
Closes micrometer-metricsgh-3556
96a21a0
Successfully merging a pull request may close this issue.
Describe the bug
Hazelcast has two variations for IMap writing, "put" and "set".
Hazelcast's Spring Cache uses the latter
(https://github.com/hazelcast/hazelcast/blob/master/hazelcast-spring/src/main/java/com/hazelcast/spring/cache/HazelcastCache.java#L114)
Micrometer counts the former (https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java#L125)
It should use
localMapStats.getPutOperationCount() + localMapStats.getSetOperationCount()
Environment
N/a
To Reproduce
I don't have code, but anything
@Cacheable
in Spring that saves to Hazelcast should be enough.Expected behavior
Cache "put" counts should report as non-zero
Additional context
See also hazelcast/hazelcast#23063, which may change the implement from IMap set to IMap put
The text was updated successfully, but these errors were encountered: