Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix for partial step values on closing publish #3759

Closed
shakuzen opened this issue Apr 10, 2023 · 1 comment
Closed

Backport fix for partial step values on closing publish #3759

shakuzen opened this issue Apr 10, 2023 · 1 comment
Labels
bug A general bug module: micrometer-core An issue that is related to our core module
Milestone
1.9.11

Comments

@shakuzen
Copy link
Member

Consider backporting #1882 once we have got feedback on the solution released in milestones and are confident to release it as GA.
@shakuzen shakuzen added bug A general bug module: micrometer-core An issue that is related to our core module labels Apr 10, 2023
@shakuzen shakuzen added this to the 1.9.x milestone Apr 10, 2023
@shakuzen shakuzen mentioned this issue Apr 12, 2023
Closed
@shakuzen shakuzen modified the milestones: 1.9.x, 1.9.11 Apr 18, 2023
@jonatan-ivanov
Copy link
Member

I back-ported this to 1.9.x, here are the are the changes I applied (in this order): tree/backport-fix-for-partial-step-values

  1. Manual rollover of step meters for publishing partial step #3681 (1390610)
  2. Polish "Manual rollover of step meters for publishing partial step" #3704 (dfa43ef)
  3. Avoid duplicate publishing of data. #3714 (fddaf12)
  4. Do not rollover again after closing #3730 (4e64b29)
  5. Polish "Avoid concurrent publish calls from publishSafely" #3733 (fe07e98)
  6. Polish "Do not rollover again after closingRollover" #3737 (f82cdbc)
  7. Fix @Nullable import (bbea7b6): this was needed because we renamed the package of @Nullable in 1.10.0 and deprecated the old one

While I was discovering what changes are related (file history) I found #3750 and #3793 but we should not include them.

jonatan-ivanov added a commit that referenced this issue May 4, 2023
@jonatan-ivanov
Fix @nullable import
8a53a77 
Since we changed the package name in 1.10.0 and the previous backport
commit used what was available in 1.9.x and deprecated in 1.10.x

See 82dff93
See gh-3759
@shakuzen shakuzen mentioned this issue Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.9.11
Development

No branches or pull requests
2 participants
@jonatan-ivanov @shakuzen