Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to disable LongtaskTimer creation in DefaultMeterObservationHandler #4604

Closed
jonatan-ivanov opened this issue Jan 19, 2024 · 1 comment · Fixed by #4755
Closed

Make it possible to disable LongtaskTimer creation in DefaultMeterObservationHandler #4604

jonatan-ivanov opened this issue Jan 19, 2024 · 1 comment · Fixed by #4755
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module spring-boot change Change is needed in Spring Boot for this issue
Milestone
1.13.0-M2

Comments

@jonatan-ivanov
Copy link
Member

There are users who does not want to sacrifice extra CPU cycles for creating a LongtaskTimer every time they create an Observation. This could also save network and storage/backend costs since those extra time series will not be there.
@jonatan-ivanov jonatan-ivanov added the enhancement A general enhancement label Jan 19, 2024
@jonatan-ivanov jonatan-ivanov mentioned this issue Jan 19, 2024
Closed
@shakuzen shakuzen added this to the 1.13 backlog milestone Jan 23, 2024
@jonatan-ivanov jonatan-ivanov linked a pull request Feb 29, 2024 that will close this issue
Make LongTaskTimer creation conditional in DefaultMeterObservationHandler #4755
Merged
@jonatan-ivanov jonatan-ivanov added the spring-boot change Change is needed in Spring Boot for this issue label Feb 29, 2024
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.13.x, 1.13.0-M2 Feb 29, 2024
@jonatan-ivanov
Copy link
Member Author

Fixed in #4755

@shakuzen shakuzen added the module: micrometer-core An issue that is related to our core module label Feb 29, 2024
@bclozel bclozel mentioned this issue May 27, 2024
Closed
@jonatan-ivanov jonatan-ivanov mentioned this issue Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module spring-boot change Change is needed in Spring Boot for this issue
Projects
None yet
Milestone
1.13.0-M2
Development

Successfully merging a pull request may close this issue.

Make LongTaskTimer creation conditional in DefaultMeterObservationHandler jonatan-ivanov/micrometer
2 participants
@jonatan-ivanov @shakuzen