Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatchMeterRegistry logs timeout message when there was an interrupt and does not log anything when there was a timeout #4775

Closed
jonatan-ivanov opened this issue Feb 29, 2024 · 0 comments
Assignees
Labels
bug A general bug registry: cloudwatch A CloudWatch Registry related issue
Milestone

Comments

@jonatan-ivanov
Copy link
Member

CloudWatchMeterRegistry says "metrics push to cloudwatch took longer than expected" when the execution was interrupted:

try {
@SuppressWarnings("deprecation")
long readTimeoutMillis = config.readTimeout().toMillis();
latch.await(readTimeoutMillis, TimeUnit.MILLISECONDS);
}
catch (InterruptedException e) {
logger.warn("metrics push to cloudwatch took longer than expected");
throw e;
}

At the same time the result of CountdownLatch::await is not handled so there is no message when timeout happens.

@jonatan-ivanov jonatan-ivanov added this to the 1.9.18 milestone Feb 29, 2024
@jonatan-ivanov jonatan-ivanov self-assigned this Feb 29, 2024
@jonatan-ivanov jonatan-ivanov added the registry: cloudwatch A CloudWatch Registry related issue label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug registry: cloudwatch A CloudWatch Registry related issue
Projects
None yet
Development

No branches or pull requests

1 participant