Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing PrometheusProperties via PrometheusConfig #4875

Closed
jonatan-ivanov opened this issue Mar 28, 2024 · 0 comments · Fixed by #4921
Closed

Allow customizing PrometheusProperties via PrometheusConfig #4875

jonatan-ivanov opened this issue Mar 28, 2024 · 0 comments · Fixed by #4921
Labels
enhancement A general enhancement registry: prometheus A Prometheus Registry related issue
Milestone
1.13.0-RC1

Comments

@jonatan-ivanov
Copy link
Member

Right now we depend on the built-in configuration support of the Prometheus 1.x client through PrometheusProperties. This lets users use the default properties mechanism of the Prometheus Client but it can also be weird to users who used to the config system of Micrometer or frameworks like Spring Boot since right now neither can work, users need to go through the config system of the Prometheus Client if they want to configure certain things.
@jonatan-ivanov jonatan-ivanov added the enhancement A general enhancement label Mar 28, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.13.0-RC1 milestone Mar 28, 2024
@shakuzen shakuzen added the registry: prometheus A Prometheus Registry related issue label Mar 28, 2024
@jonatan-ivanov jonatan-ivanov linked a pull request Apr 5, 2024 that will close this issue
Allow customizing PrometheusProperties via PrometheusConfig #4921
Merged
@shakuzen shakuzen changed the title Improve Prometheus 1.x config integration Allow customizing PrometheusProperties via PrometheusConfig Apr 5, 2024
shakuzen pushed a commit that referenced this issue Apr 5, 2024
@jonatan-ivanov
Allow customizing PrometheusProperties via PrometheusConfig (#4921)
7f2936a 
Passes properties from `PrometheusConfig`'s new method `prometheusProperties` to the Prometheus client's `PrometheusPropertiesLoader` so they are used along with other methods of configuring the Prometheus client.

Resolves gh-4875
This was referenced Apr 5, 2024
Closed
Closed
izeye added a commit to izeye/micrometer that referenced this issue Jun 21, 2024
@izeye
Add Javadoc since for PrometheusConfig.prometheusProperties()
13152ad 
See micrometer-metricsgh-4875
@izeye izeye mentioned this issue Jun 21, 2024
Merged
jonatan-ivanov pushed a commit that referenced this issue Jun 21, 2024
@izeye
Add Javadoc since for PrometheusConfig.prometheusProperties() (#5227)
4b2147e 
See gh-4875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement registry: prometheus A Prometheus Registry related issue
Projects
None yet
Milestone
1.13.0-RC1
Development

Successfully merging a pull request may close this issue.

Allow customizing PrometheusProperties via PrometheusConfig jonatan-ivanov/micrometer
2 participants
@jonatan-ivanov @shakuzen