Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object name for query in Tomcat metrics #1755

Merged
merged 1 commit into from Dec 16, 2019

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 16, 2019

This PR fixes object name for query in Tomcat metrics.

Closes gh-1754

@izeye izeye changed the base branch from master to 1.1.x December 16, 2019 03:59
@izeye
Copy link
Contributor Author

izeye commented Dec 16, 2019

I'm not sure why the following tests have been failed on JDK 10, especailly Jetty one:

io.micrometer.core.instrument.binder.jetty.JettyServerThreadPoolMetricsTest > threadMetrics() FAILED
    java.lang.AssertionError: 
    Expecting:
     <0.0>
    not to be equal to:
     <0.0>
        at io.micrometer.core.instrument.binder.jetty.JettyServerThreadPoolMetricsTest.threadMetrics(JettyServerThreadPoolMetricsTest.java:65)

io.micrometer.core.instrument.binder.tomcat.TomcatMetricsTest > mbeansAvailableAfterBinder() FAILED
    org.opentest4j.AssertionFailedError: 
    Expecting:
     <3.0>
    to be equal to:
     <1119.0>
    but was not.
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at io.micrometer.core.instrument.binder.tomcat.TomcatMetricsTest.checkMbeansAfterRequests(TomcatMetricsTest.java:235)
        at io.micrometer.core.instrument.binder.tomcat.TomcatMetricsTest.lambda$mbeansAvailableAfterBinder$1(TomcatMetricsTest.java:159)
        at io.micrometer.core.instrument.binder.tomcat.TomcatMetricsTest.runTomcat(TomcatMetricsTest.java:210)
        at io.micrometer.core.instrument.binder.tomcat.TomcatMetricsTest.mbeansAvailableAfterBinder(TomcatMetricsTest.java:144)

347 tests completed, 2 failed, 2 skipped

@izeye
Copy link
Contributor Author

izeye commented Dec 16, 2019

Rerunning the build has been passed. There seems to be some flakiness, but I'm not sure how.

@shakuzen shakuzen merged commit 5a6d451 into micrometer-metrics:1.1.x Dec 16, 2019
@izeye izeye deleted the gh-1754 branch December 16, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants