Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable illegal access in ExecutorServiceMetrics #2185

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add option to disable illegal access in ExecutorServiceMetrics #2185

merged 1 commit into from
Oct 29, 2020

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jul 11, 2020

This PR adds an option to disable illegal reflective accesses in ExecutorServiceMetrics.

Closes gh-2174

@izeye izeye mentioned this pull request Jul 11, 2020
Closed
shakuzen
shakuzen approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the pragmatism of this. Let's go with this, and we'll continue to explore if we can achieve the same without reflective access. If we sort that out, we can deprecate the method then.

@shakuzen shakuzen merged commit 25f1208 into micrometer-metrics:master Oct 29, 2020
@shakuzen shakuzen added this to the 1.6.0 milestone Oct 29, 2020
@shakuzen shakuzen added the enhancement A general enhancement label Oct 29, 2020
@izeye izeye deleted the gh-2174 branch October 29, 2020 12:46
This was referenced Jun 26, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Illegal reflective access by ExecutorServiceMetrics
2 participants
@izeye @shakuzen