Add counters for QueryPlanCacheHit and QueryPlanCacheMiss in HibernateMetrics #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❓ Why this contribution in HibernateMetrics and not in HibernateQueryMetrics? |
It is not per-query metrics - it is metrics across all queries, so there is not a cardinality concern with many different queries. |
shakuzen
approved these changes
Oct 29, 2020
shakuzen
approved these changes
Oct 29, 2020
Thx for this explanations, I had missed this subtility 😌 |
This was referenced Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes in Micrometer two new Hibernate Metrics : QueryPlanCacheHit and QueryPlanCacheMiss.