Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for Elasticsearch backend with API key authentication #2820

Merged
merged 2 commits into from Oct 14, 2021

Conversation

shakuzen
Copy link
Member

This adds an integration test for the API key authentication feature added by #2714, along with some refactoring of the existing test setup for easy reuse. Also upgrades the Elasticsearch version used to the latest 7.15.0.

The download progress when pulling a docker container is logged excessively at debug level. Adds a logback.xml config file to prevent such noisy debug logs from being output during test execution.
@shakuzen shakuzen added type: task A general task registry: elastic An ElasticSearch Registry related issue labels Oct 14, 2021
@shakuzen shakuzen added this to the 1.8.0-RC1 milestone Oct 14, 2021
Copy link
Contributor

@bodin bodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - running the same tests that were run with user/password but with api-key defined in the config instead.

@shakuzen shakuzen merged commit 656d1c4 into micrometer-metrics:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry: elastic An ElasticSearch Registry related issue type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants