jvm.gc.live.data.size and max not updating for optavgpause/optthruput collectors
#2874
Conversation
shakuzen
added
bug
| System.gc(); | ||
| await().timeout(200, TimeUnit.MILLISECONDS).alias("NotificationListener takes time after GC") | ||
| .untilAsserted(() -> | ||
| assertThat(registry.find("jvm.gc.live.data.size").gauge().value()).isPositive()); |
There was a problem hiding this comment.
By forcing a GC and waiting for the notification listener to update metrics, this test does a much better job of ensuring expected metrics are available for the configured collector.
| await().timeout(200, TimeUnit.MILLISECONDS).alias("NotificationListener takes time after GC") | ||
| .untilAsserted(() -> | ||
| assertThat(registry.find("jvm.gc.live.data.size").gauge().value()).isPositive()); | ||
| assertThat(registry.find("jvm.gc.memory.allocated").counter().count()).isPositive(); |
There was a problem hiding this comment.
This metric is still missing for optavgpause and optthruput due to the allocation pool name not being set. We don't have a CI job run with OpenJ9 because we're still waiting for CI images (possibly CircleCI-Public/cimg-openjdk#78). I think we can fix the missing allocated counter separately from this pull request because it is still an improvement to get rid of the NPE which allows updating of the live and max data size gauges.
With the OpenJ9 non-generational collectors `optavgpause` and `optthruput`, a NPE was happening in the notification listener which caused some code in it to not be executed. Namely, setting the live and max data size was being effectively skipped for these collectors. Now we check for `null` and only the allocated bytes counter is skipped when no allocation pool name is set.
shakuzen
force-pushed
the
j9-nongen-gc-fixes
branch
from
3b6316b
to
305ebd3
Compare
|
|
||
| assumeTrue(binder.isGenerationalGc); |
There was a problem hiding this comment.
When the condition failed, the whole test was marked as skipped, but if we want to use this same test for generational and non-generational collectors, we should run the part of this test before here for both and report it as passed (not skipped) for non-generational collectors if all assertions passed before here.
shakuzen
changed the title
jvm.gc.live.data.size and max not updating for optavgpause/optthruput collectors
With the OpenJ9 non-generational collectors
optavgpauseandoptthruput, a NPE was happening in the notification listener which caused some code in it to not be executed. Namely, setting the live and max data size was being effectively skipped for these collectors.Now we check for
nulland only the allocated bytes counter is skipped when no allocation pool name is set.