Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ReactorNettySenderTest #2884

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Deprecate ReactorNettySenderTest #2884

merged 1 commit into from
Dec 6, 2021

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 4, 2021

This PR deprecates ReactorNettySenderTest as it causes the following warning:

> Task :micrometer-test:compileTestJava
/Users/user/IdeaProjects/micrometer/micrometer-test/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTest.java:21: warning: [deprecation] ReactorNettySender in io.micrometer.core.ipc.http has been deprecated
        return new ReactorNettySender();
                   ^
1 warning

@izeye izeye changed the base branch from main to 1.8.x December 4, 2021 11:56
@jonatan-ivanov jonatan-ivanov merged commit faaf305 into micrometer-metrics:1.8.x Dec 6, 2021
@jonatan-ivanov jonatan-ivanov added the type: task A general task label Dec 6, 2021
@jonatan-ivanov jonatan-ivanov added this to the 1.8.1 milestone Dec 6, 2021
@jonatan-ivanov jonatan-ivanov added the module: micrometer-test An issue that is related to our TCK label Dec 6, 2021
@izeye izeye deleted the reactor-netty-sender branch December 6, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

Assignees
No one assigned
Labels
module: micrometer-test An issue that is related to our TCK type: task A general task
Projects
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @jonatan-ivanov