Prevent CompositeMeter allocating on each record #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrentDouglas Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@BrentDouglas Thank you for signing the Contributor License Agreement! |
BrentDouglas
force-pushed
the
record-alloc
branch
2 times, most recently
from
ca5c8de
to
70ec6f9
Compare
shakuzen
added
module: micrometer-core
BrentDouglas
force-pushed
the
record-alloc
branch
from
70ec6f9
to
d40ad6b
Compare
|
@shakuzen I updated this to avoid all the weird signatures and just return the iterable, seems a lot cleaner |
The way forEachChild was written mean each lambda has to close over the argument which results in an allocation for each call. Instead we slightly rewrite the forEachChild api to allow passing through the data to each call so that the lambdas do not need to capture the argument.
shakuzen
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way forEachChild was written mean each lambda has to close over the
argument which results in an allocation for each call. Instead we
slightly rewrite the forEachChild api to allow passing through the data
to each call so that the lambdas do not need to capture the argument.