Simplify tests after Dynatrace Metric Utils 1.5.0 release #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
registry: dynatrace
|
Could you rebase onto the |
pirgeo
force-pushed
the
update-dynatrace-dependency
branch
from
4e227ec
to
d157996
Compare
|
Hey @shakuzen, thanks for taking a look. I think the problem might be that this is a fork in our organization, and I think for organizational forks Edit: I updated the PR to allow maintainers to modify it. Thanks again! |
jonatan-ivanov
added a commit
that referenced
this pull request
Mar 15, 2022
File polling seems to be fixed in the latest Dynatrace lib so we can lower the await timeouts in tests related: gh-3065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3035
This PR simplifies the tests after we made a method for testing public in the
DynatraceFileBasedConfigurationProvider, thanks @jonatan-ivanov for pointing it out: #2916 (comment).The newly released version of the Dynatrace utility library (1.5.0) should also fix the behavior where tests take a long time on macOS, due to a FilePolling implementation that only polled for changes every 10s.