Common ResponseContext interface for interacting with the response #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...a/io/micrometer/core/instrument/observation/ObservationOrTimerCompatibleInstrumentation.java
Show resolved
Hide resolved
shakuzen
force-pushed
the
response-context
branch
from
21bf07e
to
03659c0
Compare
Without this, we need to check two different types (currently) that have the same getter/setter methods for response. This allows us to use a common interface as shown by the changes in ObservationOrTimerCompatibleInstrumentation.
shakuzen
force-pushed
the
response-context
branch
from
03659c0
to
49e9c5e
Compare
marcingrzejszczak
approved these changes
Aug 19, 2022
jonatan-ivanov
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we need to check two different types (currently) that have the same getter/setter methods for response. This allows us to use a common interface as shown by the changes in ObservationOrTimerCompatibleInstrumentation.
This is a follow-up to #3357 (comment)