signalfx: add tests for emiting percentile and histograms, fix timer #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
testwithpercentile
branch
from
52e9ec4
to
b00787f
Compare
bogdandrutu
commented
Aug 23, 2022
| @@ -98,7 +98,8 @@ public HistogramSnapshot takeSnapshot() { | |||
| currentSnapshot.total(), // Already delta in sfx implementation | |||
| currentSnapshot.max(), // Max cannot be calculated as delta, keep the | |||
| // current. | |||
| null, // No percentile values | |||
| currentSnapshot.percentileValues(), // No changes to the percentile | |||
There was a problem hiding this comment.
This was a bug, which was fixed in DistributionSummary, but now we have tests for this as well to ensure no future problems.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
testwithpercentile
branch
from
b00787f
to
34145fe
Compare
shakuzen
approved these changes
Aug 24, 2022
shakuzen
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com