Tck with observations #3410
Merged
Tck with observations #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcingrzejszczak
force-pushed
the
tck_with_observations
branch
from
abe36c1
to
38caf91
Compare
shakuzen
reviewed
Sep 14, 2022
...ain/java/io/micrometer/core/instrument/HttpClientTimingInstrumentationVerificationTests.java
Outdated
Show resolved
Hide resolved
marcingrzejszczak
force-pushed
the
tck_with_observations
branch
2 times, most recently
from
f234368
to
b328e2d
Compare
marcingrzejszczak
force-pushed
the
tck_with_observations
branch
from
b328e2d
to
38336ff
Compare
shakuzen
approved these changes
Sep 16, 2022
| // Allows parameter resolution in BeforeEach and AfterEach | ||
| // Based on | ||
| // https://code-case.hashnode.dev/how-to-pass-parameterized-test-parameters-to-beforeeachaftereach-method-in-junit5 | ||
| static class AfterBeforeParameterResolver implements BeforeEachMethodAdapter, ParameterResolver { |
There was a problem hiding this comment.
It's a shame we need to maintain this code here, but unless junit-team/junit5#944 is implemented, I guess we don't have much of a choice.
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Oct 3, 2022
shakuzen
pushed a commit
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.