Add tests for OtlpConfig.resourceAttributes() #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds System Stubs dependency and pins Mockito to 4.8.1. See micrometer-metrics#3600 (comment)
izeye
force-pushed
the
resourceAttributes
branch
from
2e0d4a8
to
b2654e8
Compare
|
I had to pin Mockito to 4.8.1 which is being used by the branch as Mockito 5 which was pulled by System Stubs requires Java 11. |
jonatan-ivanov
requested changes
Jan 30, 2023
izeye
force-pushed
the
resourceAttributes
branch
from
4fbb5f6
to
0b9ab18
Compare
jonatan-ivanov
approved these changes
Jan 30, 2023
jonatan-ivanov
added
type: task
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
OtlpConfig.resourceAttributes().This PR also adds System Stubs dependency.
See #3600 (comment)