Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Meter.Id for logging in DynatraceExporterV2 #3616

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 2, 2023

This PR changes to use Meter.Id for logging in DynatraceExporterV2 as it might help to understand #3560 or similar a bit better.

@shakuzen
Copy link
Member

shakuzen commented Feb 3, 2023

Heads up to @pirgeo about this change.

@shakuzen shakuzen added the registry: dynatrace A Dynatrace Registry related issue label Feb 3, 2023
@shakuzen shakuzen added this to the 1.9.8 milestone Feb 3, 2023
@shakuzen shakuzen added the enhancement A general enhancement label Feb 3, 2023
@pirgeo
Copy link
Contributor

pirgeo commented Feb 3, 2023

What additional info will be printed that way? I assume tags are included, right?

@shakuzen
Copy link
Member

shakuzen commented Feb 3, 2023

Yes, it will include the meter name and tags:

@Override
public String toString() {
return "MeterId{" + "name='" + name + '\'' + ", tags=" + tags + '}';
}

@shakuzen shakuzen merged commit d2fefd8 into micrometer-metrics:1.9.x Feb 3, 2023
@izeye izeye deleted the gh-3560 branch February 3, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: dynatrace A Dynatrace Registry related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants