-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WARN message when OtlpMeterRegistry fails to publish metrics #4271
Add WARN message when OtlpMeterRegistry fails to publish metrics #4271
Conversation
@antechrestos Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@antechrestos Thank you for signing the Contributor License Agreement! |
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMeterRegistry.java
Outdated
Show resolved
Hide resolved
Thank you for the PR! |
@jonatan-ivanov of course. I will do it by tomorrow with your suggestion. |
@jonatan-ivanov I made the following change
Cheers |
Thank you! |
@jonatan-ivanov do i need to report the change on other branches? Which ones? I spotted that code was not really the same... |
Nope, once it is merged to a maintenance branch the person who merged it should forward merge it to the other supported branches too. I've already taken care of forward merging and resolving the merge conflicts (as you noticed, the code changed a bit). This change is now available on You can try out any latest snapshot versions, e.g.: |
Experienced this bad behaviour while plugging my application to an APM; as I configured the bad endpoint, it answered me with
403
http status, yet nothing appeared in logs, as if everything was normal. I had to use debugger to see the status.