Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LongAdder in CumulativeTimer and CumulativeDistributionSummary #4496

Merged
merged 1 commit into from Dec 19, 2023
Merged

Use LongAdder in CumulativeTimer and CumulativeDistributionSummary #4496

merged 1 commit into from Dec 19, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 18, 2023

This PR changes to use LongAdder in CumulativeTimer and CumulativeDistributionSummary like other implementations (ex. PrometheusTimer).

@izeye izeye changed the base branch from main to 1.9.x December 18, 2023 13:27
shakuzen
shakuzen approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I noticed this as well when looking at your other pull request. I'm not sure why these were different but it does seem better to use the Adder classes.

@shakuzen shakuzen added module: micrometer-core An issue that is related to our core module type: task A general task labels Dec 19, 2023
@shakuzen shakuzen added this to the 1.9.18 milestone Dec 19, 2023
@shakuzen shakuzen merged commit e988e3a into micrometer-metrics:1.9.x Dec 19, 2023
6 checks passed
@izeye izeye deleted the long-adder branch December 19, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
module: micrometer-core An issue that is related to our core module type: task A general task
Projects
None yet
Milestone
1.9.18
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @shakuzen