Downgrade to OkHttp 4.11.0 #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were on alpha versions as a result of using `latest.release` and the alphas being published to Maven central. When migrating to the TOML version catalog we kept the version the same as before. This attempts to move us off the alpha versions onto GA versions. We should not depend on any new API introduced in 5.0 alphas.
The version of the Kotlin stdlib that gets transitively pulled in from 4.11.0 matches the version we had with the previous 5.0 alpha version (Kotlin 1.8). We want to keep this consistent for compatibility's sake. It will be more important in later branches where we have Kotlin-based integrations.
We were resolving unexpected or mixed versions of Kotlin libraries based on transitive dependencies. This strictly aligns the Kotlin versions used and adds a sample that verifies our Kotlin-related code can be used with the newest version of Kotlin supported while being compiled with the oldest version supported.
shakuzen
reviewed
Jan 18, 2024
| @@ -58,7 +58,7 @@ mockito = "5.5.0" | |||
| mongo = "4.8.2" | |||
| netty = "4.1.104.Final" | |||
| newrelic-api = "5.14.0" | |||
| okhttp = "5.0.0-alpha.11" # TODO is compiling against an alpha version intentional? | |||
| okhttp = "4.11.0" | |||
There was a problem hiding this comment.
Downgraded from 4.12.0 to 4.11.0. This better matches the 5.0 alpha we were compiling against in terms of Kotlin dependencies.
| @@ -1,5 +1,5 @@ | |||
| plugins { | |||
| id "org.jetbrains.kotlin.jvm" version "1.7.22" | |||
| alias(libs.plugins.kotlin17) | |||
There was a problem hiding this comment.
We will continue using the same Kotlin plugin version. We don't want to upgrade the minor version in a maintenance release.
| @@ -82,6 +82,7 @@ dependencies { | |||
| optionalApi 'io.micrometer:context-propagation' | |||
|
|
|||
| // kotlin | |||
| optionalApi enforcedPlatform('org.jetbrains.kotlin:kotlin-bom') | |||
There was a problem hiding this comment.
Consistently enforces the kotlin library versions match the plugin version. Without enforcedPlatform, Gradle was resolving higher versions than we wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4523