[Dynatrace] debug log in exporter when no meters are registered #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pichlermarc Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
(keeping as draft until I've sorted out the CLA situation 🙂) |
|
@pichlermarc Thank you for signing the Contributor License Agreement! |
shakuzen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a debug log for when no meters are passed to
DynatraceExporterV2#export()and returns early as any code after this is a no-op.Currently, when no meters are passed to export, we don't send any requests nor do we do any other operations that would indicate that the exporter being called on any log-level, thus making it harder for users and/or support engineers to diagnose this trivial case.
cc @pirgeo