Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring transport and secure in the starter #30

Merged
merged 3 commits into from Feb 3, 2020
Merged

Support configuring transport and secure in the starter #30

merged 3 commits into from Feb 3, 2020

Conversation

making
Copy link
Contributor

@making making commented Jan 10, 2020 •
edited

This PR adds

  • management.metrics.export.prometheus.rsocket.transport
  • management.metrics.export.prometheus.rsocket.secure

so that client apps that uses the starter can configure WebSocket protocol.

I have tested it worked with following properties

management.metrics.export.prometheus.rsocket.host=prometheus-proxy-ws.cfapps.io
management.metrics.export.prometheus.rsocket.transport=websocket
management.metrics.export.prometheus.rsocket.port=8443
management.metrics.export.prometheus.rsocket.secure=true

# the endpoint to scape is https://prometheus-proxy-scrape.cfapps.io/metrics/proxy

@making
Support configuring transport and secure in the starter
664713a
@making
Set localhost to the default value of management.metrics.export.prome…
28fdfb0 
…theus.rsocket.host

so that an error doesn't occur when launching an app that just adds this library.
@making
Add license
2562fef
@shakuzen shakuzen changed the title Support configuring transport and secure and secure in the starter Support configuring transport and secure in the starter Feb 3, 2020
shakuzen
shakuzen approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shakuzen shakuzen added the enhancement New feature or request label Feb 3, 2020
@shakuzen shakuzen added this to the 0.10.0 milestone Feb 3, 2020
@shakuzen shakuzen merged commit 69d6ffe into micrometer-metrics:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@making @shakuzen