Entry point assertion class for custom assertions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Jun 28, 2022
|
@ttddyy The build is failing because of tabs vs. spaces, could you please fix it? |
|
@jonatan-ivanov ok, I have applied the rule and updated the PR. |
...crometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/TracingAssertions.java
Show resolved
Hide resolved
...crometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/TracingAssertions.java
Show resolved
Hide resolved
...crometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/TracingAssertions.java
Show resolved
Hide resolved
Currently, `assertThat` methods from custom asserts(`SpanAssert`, `SpansAssert`, `TracerAssert`) do not have an entry point assertion class. Hence, users need to static import individual assert classes. This change introduces an entry point assertion class. Users now simply static import this class and all `assertThat` methods are available for use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
assertThatmethods from custom asserts(SpanAssert,SpansAssert,TracerAssert) do not have an entry point assertionclass. Hence, users need to static import individual assert classes.
This change introduces an entry point assertion class. Users now simply
static import this class and all
assertThatmethods are available foruse.