Use CurrentTraceContext for OTel's Tracer bridge #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this commit we're not using the whole mechanism of merging scopes, baggages and checking for noops that is inbuilt in CurrentTraceContext when calling tracer.withSpan in OTel with this commit we're redirecting the calls to CurrentTraceContext fixes gh-215
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/tracing/310.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/tracing/310.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
jonatan-ivanov
approved these changes
Jul 11, 2023
Comment on lines
132
to
134
| final OtelTraceContext otelTraceContext; | ||
|
|
||
| final Context old; |
There was a problem hiding this comment.
What do you think about renaming them to currentOtelTraceContext and oldContext?
| @@ -57,6 +57,9 @@ static io.opentelemetry.api.trace.Span toOtel(Span span) { | |||
| } | |||
|
|
|||
| static Span fromOtel(io.opentelemetry.api.trace.Span span) { | |||
| if (span instanceof OtelSpan) { | |||
| return (OtelSpan) span; | |||
There was a problem hiding this comment.
Does this cast have any effect when the return type is Span anyways?
marcingrzejszczak
force-pushed
the
useCurrentTraceContextForTracer
branch
from
654e147
to
cdab30b
Compare
marcingrzejszczak
force-pushed
the
useCurrentTraceContextForTracer
branch
from
cdab30b
to
c882954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this commit we're not using the whole mechanism of merging scopes, baggages and checking for noops that is inbuilt in CurrentTraceContext when calling tracer.withSpan in OTel with this commit we're redirecting the calls to CurrentTraceContext
fixes gh-215