Fix wrong baggage scope closing order in ObservationAwareBaggageThreadLocalAccessor #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #579 . It was kind of hard to reproduce the exact problem using a test but I managed to do so via reflection (I hope that it fine). The test just sets a baggageToPropagate directly using the accessor in the main thread and then immediately closes the scopes. If you do not fix the order of the closing scopes the OTelConfig test will fail and actually will affect trailing tests because the scopes are interfering with each other. Feel free to give suggestions on how to better test this :)