Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpRequest URI returning Path instead of full uri #1848

Closed
driverpt opened this issue Aug 26, 2023 · 2 comments
Closed

HttpRequest URI returning Path instead of full uri #1848

driverpt opened this issue Aug 26, 2023 · 2 comments

Comments

@driverpt
Copy link
Contributor

Expected Behavior

When we add Query String arguments to the request and we need to add a Custom Header (i.e.: RFC 5988), Query String parameters do not appear

Example:

@Get("/somePath")
public String foo(HttpRequest<?> request) {
   return request.getURI().toASCIIString();
}

This just returns "/somePath";

Actual Behaviour

The above example only returns the path

Steps To Reproduce

This happens also in Tests

Environment Information

No response

Example Application

No response

Version

4.0.5

driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 26, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 26, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 26, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 26, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 28, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 28, 2023
driverpt added a commit to driverpt/micronaut-aws that referenced this issue Aug 28, 2023
@sdelamo sdelamo linked a pull request Aug 29, 2023 that will close this issue
sdelamo added a commit that referenced this issue Aug 29, 2023
@sdelamo
Copy link
Contributor

sdelamo commented Aug 29, 2023

I have added a test in the TCK micronaut-projects/micronaut-core#9791

Moreover, I have started a PR with test which reproduce #1853

@sdelamo
Copy link
Contributor

sdelamo commented Aug 29, 2023

closed via #1853

@sdelamo sdelamo closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants